issue_comments: 373540541

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1993#issuecomment-373540541 https://api.github.com/repos/pydata/xarray/issues/1993 373540541 MDEyOklzc3VlQ29tbWVudDM3MzU0MDU0MQ== 5635139 2018-03-15T22:17:27Z 2018-03-15T22:17:27Z MEMBER

I don't think we use anything created in _setup_windows() until we call __iter__, which IIUC is only called on non-vectorized methods.

We could: - Combine _setup_windows and __iter__: only runs the code when you need it, but would run each time __iter__ was called - Combine _setup_windows and __iter__ and cache the result: more code but only need to run the setup code once - Convert it to a generator: lower up-front cost, but more engineering and doesn't make it cheaper assuming you consumed the whole iterator anyway

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   305702311