issue_comments: 372079447

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1252#issuecomment-372079447 https://api.github.com/repos/pydata/xarray/issues/1252 372079447 MDEyOklzc3VlQ29tbWVudDM3MjA3OTQ0Nw== 6628425 2018-03-11T00:41:21Z 2018-03-11T00:41:21Z MEMBER

With these latest commits, I think the new behavior should now be completely behind the enable_netcdftimeindex option (which by default is set to False); I also added a test to make sure that calling resample on an xarray object that is indexed by a NetCDFTimeIndex raises a TypeError.

Note that because I wanted the convenience of using pytest.mark.parametrize for some tests in test_coding_times.py, I took the liberty of eliminating the class-based structure in that file. In hindsight I realize I probably could have waited to complete that job in another PR, but I got a little carried away. My apologies for adding some noise to this already large diff.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   205473898