home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 371989308

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1252#issuecomment-371989308 https://api.github.com/repos/pydata/xarray/issues/1252 371989308 MDEyOklzc3VlQ29tbWVudDM3MTk4OTMwOA== 1217238 2018-03-10T01:14:36Z 2018-03-10T01:14:36Z MEMBER

Can we potentially merge this behind a flag for now, e.g., you only get the new behavior if you explicitly set an option, e.g., xr.set_options(enable_netcdftimeindex=True)?

There's something to be said for getting code merged when it's ready, regardless of whether we are currently issuing a breaking release. This would also let the new index get some testing in before we turn it on by default.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  205473898
Powered by Datasette · Queries took 0.583ms · About: xarray-datasette