home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 371004338

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1971#issuecomment-371004338 https://api.github.com/repos/pydata/xarray/issues/1971 371004338 MDEyOklzc3VlQ29tbWVudDM3MTAwNDMzOA== 1217238 2018-03-07T02:48:16Z 2018-03-07T02:48:16Z MEMBER

Huh, that's interesting. Yes, I suppose should at least consider parametric tests using both dask's multithreaded and distributed schedulers. Though I'll note that for test we actually set the default scheduler to dask's basic non-parallelized get, for easier debugging: https://github.com/pydata/xarray/blob/54468e1924174a03e7ead3be8545f687f084f4dd/xarray/tests/init.py#L87

For #1793, the key thing would be to ensure that we run the tests in the isolated context without changing the default scheduler.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  302930480
Powered by Datasette · Queries took 1.041ms · About: xarray-datasette