home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 369108264

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1919#issuecomment-369108264 https://api.github.com/repos/pydata/xarray/issues/1919 369108264 MDEyOklzc3VlQ29tbWVudDM2OTEwODI2NA== 6815844 2018-02-28T03:19:42Z 2018-02-28T03:19:42Z MEMBER

@Zac-HD, I don't mean to drop CI-based flake8 checking. We are trying to move stickler-ci, which is a CI specific for flake8 check.

I thought if stickler works fine, travis could concentrate on testing, but stickler does not behave as what I have expected. I agree that it is not a good idea to remove flake8 check from travis at this moment.

I think that in the early stage of the development it would be nicer if we could easily distinguish between testing failure and style inconsistency, but travis just says succeeded or not. (it is possible to find it if we look deep inside the travis's log, but it requires some burden).

Do you have any idea to realize more explicit failure reporting?

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  297794911
Powered by Datasette · Queries took 161.473ms · About: xarray-datasette