issue_comments: 367776962

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1924#issuecomment-367776962 https://api.github.com/repos/pydata/xarray/issues/1924 367776962 MDEyOklzc3VlQ29tbWVudDM2Nzc3Njk2Mg== 5635139 2018-02-22T18:34:21Z 2018-02-22T18:35:06Z MEMBER

We use flake8-isort, which implements isort itself in flake8. @dopplershift do you have a view between them?

One advantage of isort is that there's a link between the formatter and the checker, so running isort can never cause errors.

But stepping back, we should think about whether we want to mandate this on every PR. It doesn't matter that much (less than flake8 imo), and it can be frustrating to have formatting errors get in the way of a PR. A tool that automatically corrects the code like @stickler-ci is great, but it doesn't support this one.

A compromise could be to put it in allowed failures in Travis? Or if people think we should add this, let's do it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   298437967