issue_comments: 367556688

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1933#issuecomment-367556688 https://api.github.com/repos/pydata/xarray/issues/1933 367556688 MDEyOklzc3VlQ29tbWVudDM2NzU1NjY4OA== 2443309 2018-02-22T03:31:58Z 2018-02-22T03:31:58Z MEMBER

@fmaussion -

Is it safe to do so? I.e. can it hide bugs in the current netCDF4 time handling?

Save the one test failure here, I think this is going to be a fairly safe change. The netcdftime module in netCDF4 is being ported to a stand-alone package (see: #1048, #1920, https://github.com/Unidata/netcdf4-python/pull/756, and #https://github.com/Unidata/netcdftime/issues/20). The same test suite is being run on the netcdftime package and we've been working through a series of integration tests with xarray (mostly painless, i.e. #1929).

Also I think after #1920 it would be good to have a bit more info in the documentation about why people should switch to netcdftime or not.

Agreed. Do you think I should include that here?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   298854863