home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 367493976

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1793#issuecomment-367493976 https://api.github.com/repos/pydata/xarray/issues/1793 367493976 MDEyOklzc3VlQ29tbWVudDM2NzQ5Mzk3Ng== 2443309 2018-02-21T22:15:09Z 2018-02-21T22:15:09Z MEMBER

Thanks all for the comments. I will clean this up a bit and request a full review later this week.

A few things to note:

  1. I have not tested save_mfdataset yet. In theory, it should work now but it will require some testing. I'll save that for another PR.
  2. I will raise an informative error message when either h5netcdf or scipy are used to write files along with distributed.
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  283388962
Powered by Datasette · Queries took 82.874ms · About: xarray-datasette