issue_comments: 366488673

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1837#issuecomment-366488673 https://api.github.com/repos/pydata/xarray/issues/1837 366488673 MDEyOklzc3VlQ29tbWVudDM2NjQ4ODY3Mw== 6815844 2018-02-18T02:56:49Z 2018-02-18T02:56:49Z MEMBER

@shoyer , thanks for the review.

These names are very descriptive, but unfortunately they are different for DataArray and Dataset, which means that users will need to write different code for different xarray types.

Agreed. Changed to_dataarray / to_dataset -> construct.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   289556132