issue_comments: 366479069

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1837#issuecomment-366479069 https://api.github.com/repos/pydata/xarray/issues/1837 366479069 MDEyOklzc3VlQ29tbWVudDM2NjQ3OTA2OQ== 1217238 2018-02-17T23:24:30Z 2018-02-17T23:24:30Z MEMBER

My final concern is about the name for these methods. Currently, you have two separate method names, to_dataset and to_dataarray(). These names are very descriptive, but unfortunately they are different for DataArray and Dataset, which means that users will need to write different code for different xarray types. I would slightly rather that we had a single method name that could be used for both, perhaps construct() or build(). Then you could write code like xarray_obj.rolling(time=100).construct(rolling_dim='window') without needing to know whether xarray_obj is a Dataset or DataArray.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   289556132