issue_comments: 365455583

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1905#issuecomment-365455583 https://api.github.com/repos/pydata/xarray/issues/1905 365455583 MDEyOklzc3VlQ29tbWVudDM2NTQ1NTU4Mw== 1217238 2018-02-14T00:40:02Z 2018-02-14T00:40:02Z MEMBER

I can create binary data from within python and then read it, but all those tests are in my software package. Duplicating that seems like a bad idea.

Right.

The goal isn't to duplicate your tests, but to provide a meaningful integration test for the xarray backend. Can we read data from PNC into xarray and do everything an xarray user would want to do with it? Testing your API with a netCDF3 file would probably be enough, assuming you have good test coverage internally.

We already have a somewhat complete test suite for netCDF data that you could probably hook into, but for reference sorts of issues that tend to come up include: - Indexing support. Do you only support basic-indexing like x[0, :5] or is indexing with integer arrays also supported? - Serialization/thread-safety. Can we simultaneously read a file with another process or thread using dask? - API consistency for scalar arrays. Do these require some sort of special API compared to non-scalar arrays? - Data types support. Are strings and datetimes converted properly into the format xarray expects?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   296561316