home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 365332360

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1885#issuecomment-365332360 https://api.github.com/repos/pydata/xarray/issues/1885 365332360 MDEyOklzc3VlQ29tbWVudDM2NTMzMjM2MA== 1386642 2018-02-13T17:01:26Z 2018-02-13T17:01:26Z CONTRIBUTOR

Sorry @nbren12 there is still a pep8 error somewhere, and you can freely make it an error as @shoyer suggests.

Hopefully, the commit I just pushed fixes this. I had some global flake8 settings that were messing with my local linting.

Note that currently the test for monotonic coords is for pcolormesh only, while it could be for all 2d plots as well.

I don't think I was having any issues with contour or contourf when I first opened the issue, but it probably does break imshow.

If we start to check input for sanity we might as well raise an error when coordinates are not regularly spaced in the imshow case.

Maybe we could leave this to a later PR.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  294089233
Powered by Datasette · Queries took 0.799ms · About: xarray-datasette