home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 365142325

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1905#issuecomment-365142325 https://api.github.com/repos/pydata/xarray/issues/1905 365142325 MDEyOklzc3VlQ29tbWVudDM2NTE0MjMyNQ== 2443309 2018-02-13T03:46:07Z 2018-02-13T03:46:07Z MEMBER

Before closing this request and opening another, I want to make sure I am clear one the extent of what I should add.

First, don't close this PR. You can just keep adding commits to your pnc-backend.

In terms of test coverage, let's start by detailing what functionality we expect the PseudoNetCDF backend to have.

  • What file formats are supported by PseudoNetCDF?
  • What roundtrip capability is expected when PseudoNetCDF is used (i.e. if I write a netCDF3 file with scipy, can I open it with PNC and get exactly the same dataset)?
  • What are PseudoNetCDF's dependencies (Python 3?, netCDF4?), are there optional dependencies?

Finally, two things that would really help grease the skids here would be:

  1. Continuous integration testing in PseudoNetCDF, at a minimum on TravicCI, but Appveyor would be great too.
  2. A conda-forge package to facilitate easy installs of PseudoNetCDF

Neither of these last two are strictly required but both are satisfied by all the other Xarray supported backends.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  296561316
Powered by Datasette · Queries took 80.041ms · About: xarray-datasette