issue_comments: 365064764

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1885#issuecomment-365064764 https://api.github.com/repos/pydata/xarray/issues/1885 365064764 MDEyOklzc3VlQ29tbWVudDM2NTA2NDc2NA== 10050469 2018-02-12T21:16:55Z 2018-02-12T21:16:55Z MEMBER

Sorry @nbren12 there is still a pep8 error somewhere, and you can freely make it an error as @shoyer suggests.

Note that currently the test for monotonic coords is for pcolormesh only, while it could be for all 2d plots as well. What I like with the current implementation is that the check happens in _infer_interval_breaks, which is only called when certain conditions are met (1D coords, or 2D coords without transform kwarg). If this check lives in the common 2d function the same conditions should be applied.

If we start to check input for sanity we might as well raise an error when coordinates are not regularly spaced in the imshow case, although I can imagine this might be more difficult to check.

Thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   294089233