issue_comments: 362796338
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/1885#issuecomment-362796338 | https://api.github.com/repos/pydata/xarray/issues/1885 | 362796338 | MDEyOklzc3VlQ29tbWVudDM2Mjc5NjMzOA== | 10050469 | 2018-02-03T10:28:27Z | 2018-02-03T10:28:27Z | MEMBER | Thanks a lot @nbren12 ! Indeed A few comments: - the tests are now failing, likely because of a type issue with time coordinates - coordinates don't have to be ascending for pcolormesh to work (see example below). Monotonically ascending and descending coordinates should work. - we need a test for this new behavior (asserting warnings) - we follow the pep8 conventions, and I think your lines are longer than the 79 character rule
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
294089233 |