issue_comments: 361766665
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/1869#issuecomment-361766665 | https://api.github.com/repos/pydata/xarray/issues/1869 | 361766665 | MDEyOklzc3VlQ29tbWVudDM2MTc2NjY2NQ== | 6153603 | 2018-01-30T23:11:57Z | 2018-01-30T23:48:44Z | CONTRIBUTOR | Now the tests pass (see comment beside the checkbox) Honestly, I'm not happy with where I put the fix in order to get the tests to pass when using the scipy backend by adding an additional test, but I didn't know where else to put the test. The test to see if the variable would be checked in prepare_variables came before the encoding could be managed in encode_cf_variable in conventions.py The alternative would be to remove the changes to scipy_.py and just have the test run only for the other engine backends and leave fixing the scipy backend for someone more familiar with it for another issue. |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
292653302 |