issue_comments: 361734459
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/1869#issuecomment-361734459 | https://api.github.com/repos/pydata/xarray/issues/1869 | 361734459 | MDEyOklzc3VlQ29tbWVudDM2MTczNDQ1OQ== | 6153603 | 2018-01-30T21:07:36Z | 2018-01-30T21:07:36Z | CONTRIBUTOR | Unit tests added in 9210dfa45428842c69b8d1835013159b1230c572. The first and the third added tests use the encoding kwarg and fail without b8fd86d5614d28254406d6f9b6d4e37383efc1be applied and pass with b8fd86d5614d28254406d6f9b6d4e37383efc1be applied, so they should catch a regression. The second added test passes both before and after b8fd86d5614d28254406d6f9b6d4e37383efc1be and was added for completeness as it pairs with the original test_explicitly_omit_fill_value, but for a coordinate. I still think nothing needs to change in the documentation as this now follows the intent of the design. I will leave it to you @shoyer or your delegate to address whether anything needs to be stated in the changelog / what's new. |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
292653302 |