home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 36102525

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/21#issuecomment-36102525 https://api.github.com/repos/pydata/xarray/issues/21 36102525 MDEyOklzc3VlQ29tbWVudDM2MTAyNTI1 1217238 2014-02-26T08:36:08Z 2014-02-26T08:36:08Z MEMBER

This looks fine to me, but while you're at it why not preserve "calendar", too? Also, you could consider writing a test :).

I like "cf_units" or perhaps "original_units". I would not keep "units" because it doesn't make sense to think of a DatetimeIndex as having units.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  28315331
Powered by Datasette · Queries took 0.821ms · About: xarray-datasette