issue_comments: 357750095

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1828#issuecomment-357750095 https://api.github.com/repos/pydata/xarray/issues/1828 357750095 MDEyOklzc3VlQ29tbWVudDM1Nzc1MDA5NQ== 5635139 2018-01-15T17:48:53Z 2018-01-15T17:48:53Z MEMBER

There are two comment-outed lines using self.assertEqual in test_dataarray and test_dataset.

That are comment-out as part of this PR? Or prior? If prior, then I think we should leave until we attempt to add those back in

We are still using some methods of TestCase class, such as assertVariableNotEqual. Can we add equivalent function to testings.py?

I think the best way of handling those is xfailing an assert_equal test, rather than having a extra -not test for each variant. I also think we should do that in a separate PR (generally am keen to get this in before there are divergences)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   288382105