issue_comments: 357562144

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1828#issuecomment-357562144 https://api.github.com/repos/pydata/xarray/issues/1828 357562144 MDEyOklzc3VlQ29tbWVudDM1NzU2MjE0NA== 5635139 2018-01-15T01:38:09Z 2018-01-15T01:38:09Z MEMBER

Tests now pass, including flake8, apart from the pytest.warns.

Given how much code this touches, I'm keen to merge this ASAP, before divergences creep in. What's the best course on 3.4? pandas is in the process of dropping it.

Alternatively I could revert the pytest.warns changes, though there isn't one clean commit to revert.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   288382105