home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 357541210

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1828#issuecomment-357541210 https://api.github.com/repos/pydata/xarray/issues/1828 357541210 MDEyOklzc3VlQ29tbWVudDM1NzU0MTIxMA== 5635139 2018-01-14T20:48:56Z 2018-01-14T20:48:56Z MEMBER

I think this is now passing throughout except for Python3.4, which I think is because pytest is on version 3.0.5, which doesn't have the match keyword from pytest 3.3.

Does anyone know why an old version of pytest is being installed there? From what I can see on the pytest home page, 3.4 is fully supported, and the 3.4 ci requirements don't force a lower version of pytest.

I could unravel that but if anyone has insight (and is anyone using 3.4? Though this PR prob not the place to make that decision)

I think we should try and merge this asap, as there are going to be (manageable) merge conflicts with other branches

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  288382105
Powered by Datasette · Queries took 0.902ms · About: xarray-datasette