issue_comments: 357442522

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1824#issuecomment-357442522 https://api.github.com/repos/pydata/xarray/issues/1824 357442522 MDEyOklzc3VlQ29tbWVudDM1NzQ0MjUyMg== 306380 2018-01-13T15:14:27Z 2018-01-13T15:14:27Z MEMBER

Huzzah. Thanks Zac for picking this up

On Sat, Jan 13, 2018 at 6:37 AM, Zac Hatfield Dodds notifications@github.com wrote:

Closes #1741 https://github.com/pydata/xarray/pull/1741 by @mrocklin https://github.com/mrocklin (who did most of the work I'm presenting here). I had an evening free, so I rebased the previous pull on master, fixed the conflicts, and then made everything pass with flake8's default settings (including line length). My condolences to whoever gets to review this diff!

The single change any non-pedant will notice: Travis now fails if there is a flake8 warning anywhere. My experience in other projects is that this is the only way to actually keep flake8 passing - it's just unrealistic to expect perfect attention to detail from every contributor, but "make the build green before we merge" is widely understood 😄

You can view, comment on, or merge this pull request online at:

https://github.com/pydata/xarray/pull/1824 Commit Summary

  • autoflake
  • autopep8
  • manual checking
  • flake8 entire codebase
  • fixup test
  • Xarray is now flake8-clean with dask settings
  • Fix all flake8 issues under default settings

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1824, or mute the thread https://github.com/notifications/unsubscribe-auth/AASszFdoOfPL0XthNrYRAMofHkVvt9uPks5tKJWKgaJpZM4RdMeC . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   288322322