issue_comments: 356383197

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1813#issuecomment-356383197 https://api.github.com/repos/pydata/xarray/issues/1813 356383197 MDEyOklzc3VlQ29tbWVudDM1NjM4MzE5Nw== 2443309 2018-01-09T19:08:59Z 2018-01-09T19:08:59Z MEMBER

You're right. That's it. Do you know what the check for np.generic is trying to do here:

https://github.com/pydata/xarray/blob/ab0db05a58fd47fe895d1a85c09c37d96263d3b7/xarray/plot/plot.py#L36-L43

All the tests seem to pass with:

Python def _valid_other_type(x, types): """ Do all elements of x have a type from types? """ return all(any(isinstance(el, t) for t in types) for el in np.ravel(x))

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   287186057