issue_comments: 356188198

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1646#issuecomment-356188198 https://api.github.com/repos/pydata/xarray/issues/1646 356188198 MDEyOklzc3VlQ29tbWVudDM1NjE4ODE5OA== 2448579 2018-01-09T05:56:25Z 2018-01-09T05:56:25Z MEMBER

I have a simple fix in #1812 .

With that change, this works.

print(xarray.concat(data, xarray.DataArray(['foo1', 'foo2', 'foo3', 'foo4', 'foo5'], name='stat'))

But if you provided a dimension name like

print(xarray.concat(data, xarray.DataArray(['foo1', 'foo2', 'foo3', 'foo4', 'foo5'], dims=['new_dim'], name='stat'))

then new_dim is renamed to stat. What is the desired behaviour in this case viz. do we preserve dimension name new_dim or assign new name stat?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   267521588