issue_comments: 355813988

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1787#issuecomment-355813988 https://api.github.com/repos/pydata/xarray/issues/1787 355813988 MDEyOklzc3VlQ29tbWVudDM1NTgxMzk4OA== 1197350 2018-01-07T10:52:54Z 2018-01-07T10:52:54Z MEMBER

Perhaps we could default to “units” for the unit attribute but allow a custom attribute to be set via xarray.set_options?

Sent from my iPhone

On Jan 7, 2018, at 11:15 AM, Fabien Maussion notifications@github.com wrote:

In general I'm in favor for this change: adding units to the colorbar is the the first thing I teach my students in class. afaik, we don't do anything with units in xarray (except time handling), so this would be a first time thing and @shoyer maybe wants to chime in here.

Also:

other labels could print their units too: coordinates on x and y axis labels might have units, e.g. lons/lats (the same way you added it to the y-label for 1d plots). are parentheses Velocity (m/s) the correct way to represent units in graphics? I got used to brackets Velocity [m/s] and thought this was the standard but internet and stackoverflow seem to have various opinions on the matter there should be tests for this. The fact that your change didn't break anything is that we have no data attribute called units in the graphics test suite: we should change this if we go for this change. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   282369945