home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 352888557

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1785#issuecomment-352888557 https://api.github.com/repos/pydata/xarray/issues/1785 352888557 MDEyOklzc3VlQ29tbWVudDM1Mjg4ODU1Nw== 1217238 2017-12-19T21:15:13Z 2017-12-19T21:15:13Z MEMBER

Well, this behaviour is analogous to automatically choosing x,y in _plot2d. xarray is already pretty opinionated in this respect.

We use the order of the dimensions on the array for choosing how to plot it. The analogous behavior would be to always plot longer dimension along the x-axis, which isn't what we do.

The current behaviour for a 10000x3 array is to plot 10000 lines which is bad. I'm OK with adding an error message but strongly feel that choosing to plot 3 lines (i.e. always smallest number of lines) is a good default.

I agree that users probably rarely want 10,000 lines :). That's a good reason to require an explicit choice here.

The problem are edge cases like a 5x6 array. Do you want 5 lines of 6 points each or 6 lines of 5 points each? If we make the heuristic depend on the size of the array, then it will give very hard to understand what happens when the array shape changes slightly.

Re:error, would that be a message stating that either x or hue be specified if the input is 2D?

Yes, that sounds right.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  282339218
Powered by Datasette · Queries took 0.492ms · About: xarray-datasette