issue_comments: 352397809

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1712#issuecomment-352397809 https://api.github.com/repos/pydata/xarray/issues/1712 352397809 MDEyOklzc3VlQ29tbWVudDM1MjM5NzgwOQ== 4414299 2017-12-18T11:17:33Z 2017-12-18T11:17:33Z CONTRIBUTOR

@fmaussion Seems okay to me. The rasterio version check is a bit iffy but I can't think of a way to do it better.

I do agree with @snowman2 though, having the coordinate generation separately exposed would be nice (and easier to write unit tests for). Something like ```python def xy_pixel_coordinates(nx, ny, transform=None) transform = Affine.identity if not transform else transform

# xarray coordinates are pixel centered
x, _ = (np.arange(nx)+0.5, np.zeros(nx)+0.5) * transform
_, y = (np.zeros(ny)+0.5, np.arange(ny)+0.5) * transform
return x,y

``` would probably suffice, though I don't know which module this would fall under. I'd imagine it might be useful for backends besides rasterio, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   273268690