issue_comments: 352181503

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1785#issuecomment-352181503 https://api.github.com/repos/pydata/xarray/issues/1785 352181503 MDEyOklzc3VlQ29tbWVudDM1MjE4MTUwMw== 10050469 2017-12-16T12:48:40Z 2017-12-16T12:48:40Z MEMBER

Looks quite good! Thanks.

Sorry to be annoying ;), but there should be tests for the features you document:

  • x : string, optional
  • Coordinate for x axis (2D inputs only). If None use darray.dims[1]
  • add_legend : boolean, optional
  • Add legend with y axis coordinates (2D inputs only).

Currently, choosing another dim for the x axis and the legend kwargs are not tested.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   282339218