home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 351470450

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1745#issuecomment-351470450 https://api.github.com/repos/pydata/xarray/issues/1745 351470450 MDEyOklzc3VlQ29tbWVudDM1MTQ3MDQ1MA== 1217238 2017-12-13T17:54:54Z 2017-12-13T17:54:54Z MEMBER

@braaannigan Can you share the name of your problematic file?

One possibility is that re.search() is not thread-safe, even though I don't think we call is_remote_uri from multiple threads. We can test that by adding a lock, and seeing if that resolves the issue. Try replacing is_remote_uri with: ```python import threading

LOCK = threading.Lock()

def is_remote_uri(path): with LOCK: return bool(re.search('^https?\://', path)) ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  277538485
Powered by Datasette · Queries took 79.049ms · About: xarray-datasette