issue_comments: 349537178

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1759#issuecomment-349537178 https://api.github.com/repos/pydata/xarray/issues/1759 349537178 MDEyOklzc3VlQ29tbWVudDM0OTUzNzE3OA== 1217238 2017-12-06T05:20:29Z 2017-12-06T05:20:29Z MEMBER

OK, I figured it out. We set dask.set_options(get=dask.get) in xarray/tests/__init__.py, which is convenient for debugging (warning: changing global state!). Naturally, that means dask ignores the value of __dask_scheduler__ attribute.

I don't really have better ideas for how to test this, but it is reassuring that __dask_scheduler__ is the only attribute where we could reasonably expect to encounter this issue and its implementation is basically trivial. I suppose we could make one basic sanity test where we test each xarray data structure using the default scheduler. Possibly it would also make sense to change the scheduler explicitly (e.g., via a helper function for equality checks) rather than overloading it for all tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   279161550