issue_comments: 348569223

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1528#issuecomment-348569223 https://api.github.com/repos/pydata/xarray/issues/1528 348569223 MDEyOklzc3VlQ29tbWVudDM0ODU2OTIyMw== 1217238 2017-12-01T18:20:32Z 2017-12-01T18:20:32Z MEMBER

To finish it up, I propose to raise an error when attempting to encode variable-length string data. If someone can give me a quick one liner to help identify such datatypes, that would be helpful.

Variable length strings are stored with dtype=object. So something like dtype.kind == 'O' should work.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   253136694