issue_comments: 348564159
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/1528#issuecomment-348564159 | https://api.github.com/repos/pydata/xarray/issues/1528 | 348564159 | MDEyOklzc3VlQ29tbWVudDM0ODU2NDE1OQ== | 1197350 | 2017-12-01T17:58:59Z | 2017-12-01T17:59:06Z | MEMBER | Sorry this has become such a behemoth. I know it is hard to review. I couldn't see how to make a more atomic PR because a new backend has lots of interrelated parts that need each other in order to work. To finish it up, I propose to raise an error when attempting to encode variable-length string data. If someone can give me a quick one liner to help identify such datatypes, that would be helpful. We will revisit these encoding issues once Stephan's refactoring is merged. |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
253136694 |