home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 347624156

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1743#issuecomment-347624156 https://api.github.com/repos/pydata/xarray/issues/1743 347624156 MDEyOklzc3VlQ29tbWVudDM0NzYyNDE1Ng== 1217238 2017-11-28T18:46:54Z 2017-11-28T18:47:24Z MEMBER

cc @fujiisoup

It looks like we forgot to update DataArray.__setitem__ to handle conversion of DataArray -> Variable objects, which we do for __getitem__ in Dataset._validate_indexers. DataArray.__setitem__ currently just passes on the key directly to Variable.__setitem__.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  277441150
Powered by Datasette · Queries took 4.373ms · About: xarray-datasette