home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 346284465

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1735#issuecomment-346284465 https://api.github.com/repos/pydata/xarray/issues/1735 346284465 MDEyOklzc3VlQ29tbWVudDM0NjI4NDQ2NQ== 10050469 2017-11-22T08:56:02Z 2017-11-22T08:56:02Z MEMBER

Thanks for the PR! It seems that your changes broke some tests. Could you have a look?

Also, it would be good to add a test for this feature. Here are the tests for facetgrids, and here is an example for the 2d plots cbar kwargs tests as a template.

Finally, if you have time it would be great to add an example in the docs ;). The easiest would be to add a cbar_kwargs kw to the call to facetgrid in this example. Thanks a lot!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  275943854
Powered by Datasette · Queries took 1.235ms · About: xarray-datasette