issue_comments: 343762924
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/issues/1686#issuecomment-343762924 | https://api.github.com/repos/pydata/xarray/issues/1686 | 343762924 | MDEyOklzc3VlQ29tbWVudDM0Mzc2MjkyNA== | 10050469 | 2017-11-12T20:00:21Z | 2017-11-12T20:00:21Z | MEMBER | I'm afraid I don't know rasterio well enough to be able to take a decision here. However the fact that rasterio throws a warning when using your code above is not a good sign, and I don't think we have to take action in xarray (yet). I am however also not super happy with this bit of code here: https://github.com/pydata/xarray/blob/014b7898a65d9406a0e9af0ab7166702b6e977b3/xarray/backends/rasterio_.py#L136-L142 It works for all the cases I've encountered until now, but it feels like this logic should be available in rasterio already. |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
271000579 |