home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 343601202

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1583#issuecomment-343601202 https://api.github.com/repos/pydata/xarray/issues/1583 343601202 MDEyOklzc3VlQ29tbWVudDM0MzYwMTIwMg== 4414299 2017-11-10T22:13:48Z 2017-11-10T22:13:48Z CONTRIBUTOR

@jhamman Any comments on the current implementation? I'm not sure how to handle possible collisions with the tag parsing and existing xarray attributes / coordinates with the same name.

Also, while writing the test for this, I found out that rasterio < 1.0a doesn't support saving the tags to the file, so I added a version check there.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  259058863
Powered by Datasette · Queries took 0.583ms · About: xarray-datasette