issue_comments: 343236205

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1705#issuecomment-343236205 https://api.github.com/repos/pydata/xarray/issues/1705 343236205 MDEyOklzc3VlQ29tbWVudDM0MzIzNjIwNQ== 1217238 2017-11-09T17:51:40Z 2017-11-09T17:51:40Z MEMBER

There's been discussion about abstract classes on the NumPy mailing list. It would be nice to use something standard if possible: https://mail.python.org/pipermail/numpy-discussion/2017-November/thread.html#77312

On Thu, Nov 9, 2017 at 6:19 AM Keisuke Fujii notifications@github.com wrote:

This looks pretty clean and less error-prone.

For more cleanliness, I'm wondering if we could more clearly distinguish between raw array-wrappers (such as NumpyIndexingAdapter) and wrappers of array-wrapper (such as MemoryCachedArray). But as a whole, I like this idea.

Regarding the more array-type support in the future (as suggested in comment https://github.com/pydata/xarray/issues/1617#issuecomment-340290288), is there something to prepare in this PR? I guess there are some typical indexing types, such as Fortran-type and Numpy-type. Can we have some abstract classes (maybe too early)?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1705#issuecomment-343167809, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1tRYI6F0WTmR9ozdBdvy0g6Yi-Ipks5s0wnagaJpZM4QXhhG . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   272460887