home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 341740088

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1687#issuecomment-341740088 https://api.github.com/repos/pydata/xarray/issues/1687 341740088 MDEyOklzc3VlQ29tbWVudDM0MTc0MDA4OA== 10050469 2017-11-03T15:38:52Z 2017-11-03T15:38:52Z MEMBER

My reasoning (I guess) was that we shouldn't create Dataset objects which cannot be serialized to NetCDF (for whatever reason, for example because we store rasterio objects of some kind), since NetCDF is the preferred way to serialize xarray objects.

I don't mind removing these, but then the test names should be renamed too (test_serialization_platecarree -> test_platecarree)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  271017521
Powered by Datasette · Queries took 0.649ms · About: xarray-datasette