issue_comments: 341577210

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1682#issuecomment-341577210 https://api.github.com/repos/pydata/xarray/issues/1682 341577210 MDEyOklzc3VlQ29tbWVudDM0MTU3NzIxMA== 5635139 2017-11-02T22:29:45Z 2017-11-02T22:29:45Z MEMBER

This looks great so far!

But have you tested this? I have a suspicion that putting OPTIONS['engine'] as a default arg won't work: whenever the relevant function is imported, the default will be set to the value at that time, and won't change if the options dictionary is later modified.

You could have a default arg of None and then look up the option within the function, if my suspicions are right

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   270677100