issue_comments: 338575260

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1647#issuecomment-338575260 https://api.github.com/repos/pydata/xarray/issues/1647 338575260 MDEyOklzc3VlQ29tbWVudDMzODU3NTI2MA== 1217238 2017-10-23T07:48:56Z 2017-10-23T07:48:56Z MEMBER

It occurs to me that yet another option is to avoid using _FillValue:

  1. Instead of using _FillValue, set the missing_value attribute, which is not directly used by netCDF libraries. We could thus choose to let missing_value be a unicode string, and do comparison to find missing values after decoding back into unicode. In contrast, _FillValue is required to be a valid scalar for the encoded netCDF variable, which means a single bytes character when using character encoding. It's pretty awkward for valid choices of _FillValue to change based on which netCDF library / version is being used, so I'd really like to avoid that. (In the current version of https://github.com/pydata/xarray/pull/1648, I resolve this issue by encoding unicode fill values into bytes, but this means you need to know that your unicode character encodes into a single byte.)
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   267542085