home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 338367037

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1609#issuecomment-338367037 https://api.github.com/repos/pydata/xarray/issues/1609 338367037 MDEyOklzc3VlQ29tbWVudDMzODM2NzAzNw== 1217238 2017-10-21T06:06:16Z 2017-10-21T06:06:16Z MEMBER

@jhamman I think this is something to do with string/bytes. The data gets written as Unicode strings but then read back in as bytes, which is obviously not ideal.

If you want to ignore this, like the current tests, you can use assert_allclose() which has a flag for ignoring string/bytes issues (yeah, I know it's a nasty hack). In the long run we need to figure out how to solve issues like https://github.com/pydata/xarray/issues/1638. It seems like https://github.com/Unidata/netcdf-c/issues/402 is likely relevant.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  262930380
Powered by Datasette · Queries took 80.732ms · About: xarray-datasette