issue_comments: 337631240

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1635#issuecomment-337631240 https://api.github.com/repos/pydata/xarray/issues/1635 337631240 MDEyOklzc3VlQ29tbWVudDMzNzYzMTI0MA== 1217238 2017-10-18T15:31:56Z 2017-10-18T15:31:56Z MEMBER

Note that ndarray.argsort(axis=None) sorts the flattened array, so the returned DataArray should respect this

I'm not a huge fan of auto-flattening for xarray, but I can see this logic.

Alternative suggestion: have DataArray.argsort() return an ndarray filled with labels from the sorted dimension

I would probably implement a new method for this, maybe idxsort for symmetry with idxmax (https://github.com/pydata/xarray/issues/60). Though that name could be read several different ways. Maybe sortby_labels()?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   266133430