issue_comments: 336637245

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1632#issuecomment-336637245 https://api.github.com/repos/pydata/xarray/issues/1632 336637245 MDEyOklzc3VlQ29tbWVudDMzNjYzNzI0NQ== 6815844 2017-10-14T14:10:18Z 2017-10-14T14:10:18Z MEMBER

I added a tab-completion support also for ds.coords and ds.data_vars.

I am getting to feel slight unnaturalness against the following behavior.

```python In [1]: import xarray as xr ...: da = xr.Dataset({'var1': ('x', [0, 1, 2])})

In [2]: 'x' in da Out[2]: False

In [3]: 'x' in da.keys() Out[3]: False

In [4]: da['x'] Out[4]: <xarray.DataArray 'x' (x: 3)> array([0, 1, 2]) Dimensions without coordinates: x ```

I understand that it is a designed behavior, but it looks a little bit unintuitive.

Maybe 'x' in da should be True?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   265344609