issue_comments: 334543078

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1611#issuecomment-334543078 https://api.github.com/repos/pydata/xarray/issues/1611 334543078 MDEyOklzc3VlQ29tbWVudDMzNDU0MzA3OA== 15826727 2017-10-05T17:56:07Z 2017-10-05T17:56:42Z CONTRIBUTOR

@jhamman okay I figured it out, added the tests, confirmed that the Nio tests get run, and they all pass (other than a dask test, but I think that's expected right now?). But, I'm getting some strange results from git diff upstream/master | flake8 --diff, on lines that I did not modify, and some lines that I copied the syntax over from existing files (i.e., ci/requirements-py36-pynio-dev.yml, where it complains about indentation). Is this a concern? PR ready to go other than that. My branch is here: https://github.com/brhillman/xarray/tree/fix-py3-pynio-backend.

edit: oops, commented before I got your response. Opening PR now and we can iterate there...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   262966657