home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 334528039

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1611#issuecomment-334528039 https://api.github.com/repos/pydata/xarray/issues/1611 334528039 MDEyOklzc3VlQ29tbWVudDMzNDUyODAzOQ== 15826727 2017-10-05T17:00:51Z 2017-10-05T17:00:51Z CONTRIBUTOR

Okay @jhamman excuse my ignorance on the test suite, I've never worked with pytest or Travis CI before, but if I understand correctly, this would involve adding a section like: - python: 3.6 env: CONDA_ENV=py36-pynio-dev to xarray/.travis.yml, and then add a corresponding ci/requirements-py36-pynio-dev.yml file to list the dependencies for that test environment? I've gotten the tests to run and pass on my environment just by adding an entry to ci/requirements-py36.yml that reads - pynio=dev python=3 and adding an entry that reads - ncar to the "channels" section, but maybe this is the wrong place to add this?

FYI I also had to make a change to xarray/tests/__init__.py to import pynio correctly (the test would have never run, regardless of whether or not pynio because it tried to import the wrong package name).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  262966657
Powered by Datasette · Queries took 0.876ms · About: xarray-datasette