issue_comments: 334024556

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1473#issuecomment-334024556 https://api.github.com/repos/pydata/xarray/issues/1473 334024556 MDEyOklzc3VlQ29tbWVudDMzNDAyNDU1Ng== 6815844 2017-10-04T01:20:13Z 2017-10-04T01:20:13Z MEMBER

@jhamman Thanks for the review (and sorry for my late reply). I made some modifications.

@shoyer Do you have further comments about coordinate confliction?

Limitations of the current implementation are + Coordinate confliction and attachment related to reindex is still off. I think it should go with another PR. + I could not solve the 2nd issue of this comment. In your exampe, python mda.sel(x=xr.DataArray(mda.indexes['x'][:3], dims='x')) works as expected, but python mda.sel(x=xr.DataArray(mda.indexes['x'][:3], dims='z')) will attach coordinate z.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   241578773