home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 332934061

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1598#issuecomment-332934061 https://api.github.com/repos/pydata/xarray/issues/1598 332934061 MDEyOklzc3VlQ29tbWVudDMzMjkzNDA2MQ== 1217238 2017-09-28T19:05:46Z 2017-09-28T19:05:46Z MEMBER

cc @thenaomig @laliberte

There are at least two ways to fix this: 1. Support a flag of some sort in encoding (e.g., _FillValue = False) to indicate that fill value shouldn't be added. This would be easy to add, but is somewhat inelegant. 2. Check for the presence of NaNs before setting _FillValue = NaN. This would be easy to add for dimension coordinates because they are already guaranteed to be in memory, but could cause performance trouble if any inputs are loaded as dask arrays. I don't know a satisfactory way to handle dask arrays with our current design, since we don't want to add another pass over the data to check for NaNs. I suppose one option would be to refactor our backend classes to write data before writing attributes and then make some sort of dask array operation that checks for NaNs as the data is written. But I'm not even sure this would work with the standard dask task schedulers.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  261403591
Powered by Datasette · Queries took 0.616ms · About: xarray-datasette