issue_comments: 331754521

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1586#issuecomment-331754521 https://api.github.com/repos/pydata/xarray/issues/1586 331754521 MDEyOklzc3VlQ29tbWVudDMzMTc1NDUyMQ== 1217238 2017-09-25T01:20:08Z 2017-09-25T01:20:08Z MEMBER

I think this was intentional at one point, but to be honest we never carefully defined the semantics for preserving encoding are.

My original thought (along the lines of some of my comments in https://github.com/pydata/xarray/issues/1297), was that we should not propagate encoding in cases where it might no longer be valid, so it should be dropped from most operations. Essentially, encoding should only stay with original files loaded from disk. Hence why it wasn't copied in .copy().

That said, I can see why this rule would be confusing and we haven't done a good job of enforcing it. Possibly a better policy would be "encoding is copied whenever attrs is copied".

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   259935100