home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 330023143

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1473#issuecomment-330023143 https://api.github.com/repos/pydata/xarray/issues/1473 330023143 MDEyOklzc3VlQ29tbWVudDMzMDAyMzE0Mw== 1217238 2017-09-17T05:52:35Z 2017-09-17T05:52:35Z MEMBER

If k == self.name, drop the conflicted coordinate silently.

I appreciate the goal here, but this makes me a little nervous. Xarray doesn't check names for other functionality, besides deciding how to propagate names and cases where names are used to indicate how to convert a DataArray into a Dataset. So users aren't used to checking names to understand how code works.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  241578773
Powered by Datasette · Queries took 0.639ms · About: xarray-datasette