home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 330022824

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1473#issuecomment-330022824 https://api.github.com/repos/pydata/xarray/issues/1473 330022824 MDEyOklzc3VlQ29tbWVudDMzMDAyMjgyNA== 6815844 2017-09-17T05:42:01Z 2017-09-17T05:42:01Z MEMBER

How about the following case?

python target = Dataset({}, coords={'x': np.arange(3)}) indexer = DataArray([0, 1], dims=['x'], coords={'x': [2, 4]}) actual = target['x'].isel(x=indexer) Based on the above criteria, it will raise an IndexError, but I feel it should not raise an error as it is clear which one should preceds.

However, python target.isel(x=indexer) should raise an Error.

I would like to add an additional rule to take care of the first case, which might be valid only for DataArray + If k == self.name, drop the conflicted coordinate silently.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  241578773
Powered by Datasette · Queries took 0.529ms · About: xarray-datasette